[11.x] Prevent implicit route model binding parameter name mismatches in controllers #51380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on a question I asked on X, where I somewhat frequently scratch my head as to why a route model binding isn't working and a new model instance is tossed in via dependency injection. It's obvious when you show the routes together with the controller method (as you'll see below), but it's an easy mistake to make when you're in one file working with models named two or more words (
PhoneNumber
,UserInvitation
,ActivityLog
, etc.):https://twitter.com/ste_bau/status/1788976209943986419
This PR implements a way to enable throwing an exception when a model (similarly to
Model::shouldBeStrict()
) binding is missed:Then, when the first scenario above occurs, developers will immediately see the exception with clarity:
This PR doesn't affect nullable controller parameters:
It also does not affect explicit model bindings (as these are performed prior to implicit):
Let me know your thoughts! No hard feelings on closure ❤️ .