[2.x] Events for Two Factor Authentication #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you name the events "TwoFactorAuthenticationDisabled" etc. |
added 2 commits
December 18, 2020 14:26
|
@taylorotwell done! |
|
@joelbutcher @danclaytondev can any of you two send this PR and #239 to 1.x? It's unnecessary to do a new major release for those. |
joelbutcher
added a commit
to joelbutcher/fortify
that referenced
this pull request
Jan 7, 2022
* added events * dispatch events * added tests for events * Style CI fixes * rename events * fix usages (cherry picked from commit 8105a1a)
Merged
|
@driesvints Done 👍 |
taylorotwell
pushed a commit
that referenced
this pull request
Jan 7, 2022
* [2.x] Events for Two Factor Authentication (#162) * added events * dispatch events * added tests for events * Style CI fixes * rename events * fix usages (cherry picked from commit 8105a1a) * [2.x] Dispatch Event when Two Factor Challenged (#239) * dispatch event when two factor challenged and test * use statements styleci (cherry picked from commit b490728) Co-authored-by: danclaytondev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three events to fortify that get fired in the given scenarios:
I'm unsure in the last one whether or not to pass the recovery code to the event - can someone advise whether or not this would be useful?
Inspired by the closed issue on Laravel Jetstream requesting the logic be overwritten / extendable.