Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] Improve stripe statuses #707

Merged
merged 4 commits into from
Jul 19, 2019
Merged

[10.0] Improve stripe statuses #707

merged 4 commits into from
Jul 19, 2019

Conversation

driesvints
Copy link
Member

These changes sync the Stripe status within Cashier. This allows us to make better decisions when payments fail. There's also a new hasIncompletePayment method on both the billable trait and subscription model so it's easy to determine if a payment needs to be completed.

Subscriptions with an incomplete_expired status will be deleted from the app because they serve no purpose anymore.

@themsaid themsaid merged commit 2d78c82 into master Jul 19, 2019
@driesvints driesvints deleted the improve-stripe-statuses branch July 19, 2019 15:15
@pierrocknroll
Copy link

Hello @driesvints
Since 'stripe_status' is a new column, it's not a problem for people who already have data in their table ? Do you recommend to do a script to fill the status of all current subscriptions ?

@driesvints
Copy link
Member Author

@pierrocknroll technically using null in the beginning would be fine I believe but I suggest to sync with Stripe's statuses to be 100% sure everything's running okay. Your webhooks will begin updating your subscriptions normally but it's best if you do the first sync yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants