Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP and Drush versions are not configurable #49

Closed
agarzola opened this issue Feb 7, 2023 · 1 comment
Closed

PHP and Drush versions are not configurable #49

agarzola opened this issue Feb 7, 2023 · 1 comment

Comments

@agarzola
Copy link

agarzola commented Feb 7, 2023

The PHP version and Drush version are touted as configurable in the Drupal plugin doc site:

  • Configurable php version from 5.3 all the way to 8.1
  • Configurable composer and drush

However, that is not consistent with the code, as values are hardcoded for php and drush in the drupal9 recipe builder (and other recipes appear to also hardcode these values):

name: 'drupal9',
parent: '_drupaly',
config: {
confSrc: __dirname,
defaultFiles: {},
php: '8.0',
drush: '^11',
},

Indeed, the following .lando.yml config still installs PHP 8.0:

name: test-project
recipe: drupal9

config:
  php: 8.1

It would be very helpful to make these configurable, as the documentation suggests.

@agarzola
Copy link
Author

agarzola commented Feb 7, 2023

False alarm! This is actually working as intended. I was able to configure the PHP version in another project, so something must be interfering with my configuration somehow.

@agarzola agarzola closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant