Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laminas-feed still relevant for this component? #282

Closed
froschdesign opened this issue Dec 8, 2023 · 4 comments · Fixed by #291
Closed

laminas-feed still relevant for this component? #282

froschdesign opened this issue Dec 8, 2023 · 4 comments · Fixed by #291
Labels
Question Further information is requested

Comments

@froschdesign
Copy link
Member

Bug Report

Q A
Version(s) 3 & 4

Summary

laminas-feed is listed as required package for developing but is this really need?

Branch 4.0.x:

"laminas/laminas-feed": "^2.20",

Branch 3.13.x:

"laminas/laminas-feed": "^2.20",

@froschdesign froschdesign added the Question Further information is requested label Dec 8, 2023
@boesing
Copy link
Member

boesing commented Dec 9, 2023

I'd say no. I guess that was the case due to autocompletion in documentation. if laminas-feed is not mentioned in the docs anymore, we can remove that dependency.
if it is, we might want to think about moving the documentation to the feed component instead.

@Xerkus
Copy link
Member

Xerkus commented Dec 9, 2023

There is no mention of feed in the package whatsoever:

[laminas-cache (3.11.x)]$ ag feed
composer.json
56:        "laminas/laminas-feed": "^2.20",

composer.lock
<snip>

Adapters also require laminas-feed but they have no occurrences of "feed" in either source or tests.

@froschdesign
Copy link
Member Author

if laminas-feed is not mentioned in the docs anymore, we can remove that dependency.

Correct, there was an example in the documentation of version 2:

https://github.com/laminas/laminas-cache/blob/2.13.x/docs/book/pattern/class-cache.md#examples

if it is, we might want to think about moving the documentation to the feed component instead.

The example is for the removed class cache feature, so it is no longer needed.
(But the description is missed in version 2 of the laminas-cache documentation. 🤔)

@Xerkus @boesing
Thanks for your answers!

@froschdesign
Copy link
Member Author

Fixed with #291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants