Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] .Values.target.webhook.headers ignored in values.yaml (and maybe other values) #414

Closed
evgkrsk opened this issue Feb 28, 2024 · 2 comments · Fixed by #415
Closed

[Bug] .Values.target.webhook.headers ignored in values.yaml (and maybe other values) #414

evgkrsk opened this issue Feb 28, 2024 · 2 comments · Fixed by #415

Comments

@evgkrsk
Copy link

evgkrsk commented Feb 28, 2024

Looking at https://github.com/kyverno/policy-reporter/blob/main/charts/policy-reporter/config.yaml I see that .Values.target.webhook.headers is not used there and effectively ignored. I assume that other similar problems may be present with other targets as well.

Maybe it is worth to migrate to directly write .Values.target in config.yaml via toYaml ?
@fjogeleit
Copy link
Member

Hey, thanks for reporting, I'll take a look.

@fjogeleit fjogeleit linked a pull request Mar 4, 2024 that will close this issue
fix mapping of headers properties to from values.yaml to config.yaml #415
Merged
@fjogeleit
Copy link
Member

I released a fixed version.

I am working on the 3.x release which will have a restructured configuration, so I kept it simple for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix mapping of headers properties to from values.yaml to config.yaml kyverno/policy-reporter
2 participants
@evgkrsk @fjogeleit