Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array of fontScale presets #2

Closed
kyleshevlin opened this issue May 17, 2017 · 2 comments
Closed

Add array of fontScale presets #2

kyleshevlin opened this issue May 17, 2017 · 2 comments
Assignees

Comments

@kyleshevlin
Copy link
Owner

Shevy does not intend to solve anyone's font size decisions, but that doesn't mean we can't make some presets to let devs have some good options to start with.

@frytyler
Copy link
Contributor

Hey @kyleshevlin I can hit this for you, I noticed you already provide a set of defaultOptions here so is this intended to provided a set of fontScale's like multiple options to choose from. Is there an example from the scss repo?

@kyleshevlin
Copy link
Owner Author

I was considering creating some default typography scales based on tools like the following:

http:https://type-scale.com/
http:https://www.modularscale.com/

Instead of an array, it could be an object with keys that represent scales like 'major-third', 'augmented-fourth', etc, where the value is a font-scale array.

Then, the user can either pass an array or a string to font-scale and Shevy would respond accordingly. We probably want to throw an error if the key doesn't exist.

Those are my thoughts on how I was going to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants