-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close button text is visible with 'direction: rtl' #232
Comments
This project is in maintenance mode — please submit a pull request if you'd like to see this (or any other) new functionality. Thanks. |
@jlherren add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The modal's close button uses
text-indent: -9999px
to hide the "Close" text while keeping the background image attached to the link. This is usually considered bad practice and does not work withdirection: rtl
, resulting in the text being visible anyway.An alternate solution is for example proposed here: Stop using negative left or text indents for css hiding
The text was updated successfully, but these errors were encountered: