Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoother transition #185

Closed
cyphix333 opened this issue Oct 24, 2016 · 1 comment
Closed

Smoother transition #185

cyphix333 opened this issue Oct 24, 2016 · 1 comment
Labels
Improvement Needs Pull Request

Comments

@cyphix333
Copy link

Hi there and thanks for the simple modal plugin.

From what I can tell you are using JS for the transition at the moment? Just a suggestion to move over to using CSS to make the transition smoother - I have noticed at some longer transitions it can be quite jagged/laggy.

You could simply use opacity from 0% to 100% easily enough no!?
@kylefox
Copy link
Owner

kylefox commented Nov 19, 2016

I agree that CSS animations would be a great improvement, and are part of the Proposal for jQuery Modal 2.0 — pull requests welcome 👍

(The README has some information about contributing).

@kylefox kylefox closed this as completed Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Needs Pull Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kylefox @cyphix333