Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic bind links for 'rel' attribute with multiple values #135

Closed
williandandrade opened this issue Dec 14, 2015 · 1 comment
Closed

Comments

@williandandrade
Copy link

Just a little improvement for automatic binds to links.

I found this problem when i needed add "" for some SEO treatments in my projects.

Just change the selectors below to "a[rel~="modal:close"]" and "a[rel~="modal:open"]" instead of rel="...".

...

$(document).on('click.modal', 'a[rel="modal:close"]', $.modal.close);
$(document).on('click.modal', 'a[rel="modal:open"]', function (event) {
    event.preventDefault();
    $(this).modal();
});

...
@kylefox
Copy link
Owner

kylefox commented Sep 11, 2016

Good catch, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants