-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Add embedded type hints #77
Comments
I have taken approach (2) and opened a pull request to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I want to add type hints for the pyjks package. Roughly there are two ways I could achieve this:
pyjks
project directly (e.g. changedef xor_bytearrays(a, b):
->def xor_bytearrays(a: bytearray, b: bytearray) -> bytearray:
)types-pyjks
. Would make most sense to create it under the typeshed umbrella, which already maintains lots of stubs packages.Generally the Python community prefers approach (1), hence I'm trying to gauge the interest. I've noticed that the pyjks project has been static for several years now. Are there still maintainers here who could review such a PR and release a new version?
Approach (1) would also mean removing support for older Python versions, as type hints were introduced in 3.5 but are more annoying in the initial Python versions. Python 3.7 is EOL since 2 months ago and I think we should support version range 3.8 ... 3.12.
Alternatively, if maintainers aren't interested in this, I will pursue (2).
The text was updated successfully, but these errors were encountered: