fix(utils): MaybeMockedConstructor returns T #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point, `MaybeMockedConstructor` can return an empty object, causing the source type to be lost. This PR fixes this.
Pull Request Test Coverage Report for Build 5961
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At this point,
MaybeMockedConstructorcan return an empty object, causing the source type to be lost. This PR fixes this.For example, the
mocked(MyClass.prototype)function actually returns a new type that has the same properties asMyClass.prototype, but does not link toMyClass.prototype.Because of this, you cannot click on a specific property and go to the source class. For the same reason, during refactoring, renaming properties in the source class does not rename the corresponding properties in the tests.
Does this PR introduce a breaking change?