Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initiated new directory for the documentation of linux notes #97

Conversation

Vrashabh-Sontakke
Copy link

Fixes Issue

Closes #96

Changes proposed

  1. Created file structure : /docs/linux/getting_started/1._introduction.md
  2. Added assets folder : /docs/linux/assets/img/

added assets for storing images, etc... used for documentation
re-structuring the directory tree
added images
re-structuring directory tree
added assets folder for storing images and other files used in documentation
added /img/image.jpg
refined some text and added image reference from assets
Improved the definition of Linux Kernel
@Vrashabh-Sontakke
Copy link
Author

@bishal7679, would you please review my PR

@bishal7679
Copy link
Contributor

@Vrashabh-Sontakke sure!
cc @AvineshTripathi

@AvineshTripathi
Copy link
Collaborator

Please go ahead for the review if you want 🙂

@bishal7679
Copy link
Contributor

Okay @AvineshTripathi will look into it.
Thanks! 🙂

Copy link
Contributor

@bishal7679 bishal7679 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the last distro part a/q the suggestion

docs/linux/getting started/1. introduction.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bishal7679 bishal7679 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@Vrashabh-Sontakke Thanks for contributing 🎊
Take a final look @AvineshTripathi

Vrashabh-Sontakke and others added 2 commits July 21, 2022 20:35
deleted accidental extra space

Co-authored-by: Anurag  <[email protected]>
@Vrashabh-Sontakke Vrashabh-Sontakke deleted the 1-linux_notes-file-structure-for-linux-notes-inside-docs-directory branch July 21, 2022 20:39
@Vrashabh-Sontakke Vrashabh-Sontakke restored the 1-linux_notes-file-structure-for-linux-notes-inside-docs-directory branch July 22, 2022 09:45
@Vrashabh-Sontakke
Copy link
Author

Hey @kranurag7 , would you please review it now again.

@saiyam1814
Copy link
Contributor

@kranurag7 this needs your review

@kranurag7
Copy link

/lgtm

@AvineshTripathi
Copy link
Collaborator

hey @Vrashabh-Sontakke can you squash all the commits and merge into one so that I could fix the bug

@Vrashabh-Sontakke
Copy link
Author

Vrashabh-Sontakke commented Aug 11, 2022

yes

@Vrashabh-Sontakke
Copy link
Author

hey @AvineshTripathi , how do I squash merge an already open pull request

@AvineshTripathi
Copy link
Collaborator

follow this https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history and then do a force push to the same branch

Let me know if you need assistance

@AvineshTripathi
Copy link
Collaborator

@Vrashabh-Sontakke you want any help?

@saiyam1814
Copy link
Contributor

@AvineshTripathi can you check the errors please ?

@AvineshTripathi
Copy link
Collaborator

I have tried solving the issue and 50% of work is done but there is some problem with docusaurus, the page is crashing and I am trying to solve that bug

@AvineshTripathi AvineshTripathi added the hold Wait, please do not proceed this yet label Aug 20, 2022
@saiyam1814
Copy link
Contributor

No response from the original creator or the RP, closing this

@saiyam1814 saiyam1814 closed this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Wait, please do not proceed this yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] file structure for the documentation of linux notes
5 participants