Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add dark theme btn #170

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Shivansh-yadav13
Copy link

Fixes Issue

Changes proposed

  • Theme btn added in the navbar

Screenshots

Screenshot from 2022-08-23 18-00-46

Screenshot from 2022-08-23 18-00-58

Signed-off-by: Shivansh-yadav13 <[email protected]>
@AvineshTripathi AvineshTripathi added the hold Wait, please do not proceed this yet label Aug 30, 2022
@saiyam1814
Copy link
Contributor

@Shivansh-yadav13 can you check if this PR works with the latest changes and PR merged ?

@saiyam1814
Copy link
Contributor

@Shivansh-yadav13 is this PR still good ? can you please test and post screenshot so that we can merge ?

@saiyam1814
Copy link
Contributor

@Shivansh-yadav13 were you able to test this ?

@Shivansh-yadav13
Copy link
Author

@saiyam1814 sorry for late reply I found docusaurus is automatically setting the default theme to light even when I store the state in local storage. On reload it will return to light, so I will fix it and let you know.

@Shivansh-yadav13 Shivansh-yadav13 changed the title feat: add dark theme btn WIP: add dark theme btn Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Wait, please do not proceed this yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Toggle theme button is missing.
3 participants