Added space between Founder and footer section #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bishal Das <[email protected]>
|
@AvineshTripathi Please take a look __ |
| display: flex; | ||
| flex-direction: row; | ||
| background: #1B2731; | ||
| margin-bottom: 74px; |
There was a problem hiding this comment.
DO you think making this relative would be better?
There was a problem hiding this comment.
I didn't get you
Could you elaborate what do you mean by relative
Position relative or anything else
There was a problem hiding this comment.
position relative maybe in %
There was a problem hiding this comment.
You can coauthor this and I will commit your suggestion
There was a problem hiding this comment.
@bishal7679 this issue is being perfectly handled in the #175 PR by working on the footer component, If you want I can add you there as a collaborator
|
will merge this PR and do that relative thing in next PRs comming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bishal Das [email protected]
Fixes Issue #137
Closes #137
Changes proposed
Added space between Founder and footer section
Screenshots