api: revert deprecation annotation for v1 Binding #125540
Conversation
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
| @@ -6368,9 +6368,14 @@ type NamespaceList struct { | |||
| Items []Namespace `json:"items" protobuf:"bytes,2,rep,name=items"` | |||
| } | |||
|
|
|||
| // This cannot be added yet: | |||
There was a problem hiding this comment.
I don't expect this will ever be added to this type, since the type is not deprecated (it's used in the binding subresource)... maybe move this comment block to something like a unit test asserting Binding doesn't get this readded (ensuring doesn't have a APILifecycleDeprecated() method)?
There was a problem hiding this comment.
Comment removed and test added.
|
change looks fine, one comment about the comment and maybe a unit test |
kubernetes#124898 added deprecation annotations for existing types, including v1 Binding. That had the side effect of also incorrectly marking the binding sub-resource as deprecated, which in turn caused one warning in the kube-scheduler log output per scheduled pod.
872e4ea
to
5d0165d
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 22491136c17ad9384caa8faca039b3b741af7f1a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/sig api-machinery |
|
/triage accepted |
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
#124898 added deprecation annotations for existing types, including v1 Binding. That had the side effect of also incorrectly marking the binding sub-resource as deprecated, which in turn caused one warning in the kube-scheduler log output per scheduled pod.
Which issue(s) this PR fixes:
Fixes #125312
Does this PR introduce a user-facing change?
/assign @liggitt