Support BuildConfigs for openshift provider

[surajssd]

When the provider is selected as openshift and if docker-compose file has build directive then create a buildconfig out of it, along with deploymentconfig and service

[rtnpro]

I want to work on this issue.

[surajssd]

@rtnpro I am thinking of handling builds in multiple ways:

• When user has git repo create a buildconfig and imagestream using that git directory info
• But a user might also wanna do a local build, so he wants build to happen using dockerfile, so i am working on a parallel build story which will build docker images using imagebuilder and that image names can be added to deploymentconfig and made to use those images rather than pulling it from docker hub, so I am planning to add a flag to kompose cli which does this, but this assumes that user will be running a single node cluster using minikube or minishift or CDK and user will have to export some variables that enables us to talk to remote docker daemon.

[kadel]

But a user might also wanna do a local build, so he wants build to happen using dockerfile, so i am working on a parallel build story which will build docker images using imagebuilder and that image names can be added to deploymentconfig and made to use those images rather than pulling it from docker hub, so I am planning to add a flag to kompose cli which does this, but this assumes that user will be running a single node cluster using minikube or minishift or CDK and user will have to export some variables that enables us to talk to remote docker daemon.

To be honest, I don't like assumption that user is using single node cluster.
And even than I don't think that majority of users are going to run kompose on same machine where their single node cluster is running. For example if I'm using minikube I'm never going to run kompose in minikube VM.

[surajssd]

@kadel

• We assume that user will run a single node only when that flag is provided
• We can do builds on that cluster machine, only if the environment variables are exported, using imagebuilder. Remote builds are possible once we export those environments.
• User will be running kompose on his machine not on the cluster machine.

[kadel]

My issue with this is that it is quite limiting :-( This requires that you have single node cluster, and that you have remote access to that docker daemon.

Wouldn't be better to build that image locally and that push it to OpenShift's registry? We have done similar thing in OpenShift2Nulecule. This will also work with clusters. OpenShift has already internal registry and for Kubernetes we can use its registry addon as mentioned in #97 (comment)

[surajssd]

So going ahead we right now only implement what OpenShift by default provides, which is detect the source code's git remote and create buildConfigs with that info in buildconfig artifact.

Further we still have to work on doing local builds without having to rely on remote git repo.

[kadel]

So going ahead we right now only implement what OpenShift by default provides, which is detect the source code's git remote and create buildConfigs with that info in buildconfig artifact.

Just to explain this more deeply how this is example who will work:
I have cloned repo github.com/foo/bar on my local machine.
In this repo is docker-compose.yml that looks like this:

versoin: 2
services:
   foo:
      build: ./

When you run kompose on this file, kompose will try to detect remote of this git and use it as source for build.
generated BuildConfig will probably look something like this:

  apiVersion: v1
  kind: BuildConfig
  metadata:
    name: foo
  spec:
    output:
      to:
        kind: ImageStreamTag
        name: foo:latest
    source:
      type: Git
      git:
        ref: master
        uri: https://github.com/foo/bar
      contextDir: ./
    strategy:
      dockerStrategy:
        type: Docker
        from:
          kind: ImageStreamTag
          name: foo:from
    triggers:
      - type: ConfigChange
      - type: ImageChange

This means that build is not from local directory but from remote git repository.
Only what is committed and pushed to remote is build.

[dustymabe]

@sebgoa can you please assign @rtnpro to this issue?

[sebgoa]

@rtnpro you need to accept the invitation to the kompose contributor team

[sebgoa]

just a thought, is there a way to run docker in docker in a Kubernetes pod ?

[dustymabe]

just a thought, is there a way to run docker in docker in a Kubernetes pod ?

it would require root access, so it depends on how you have the cluster set up. I think overall it's not going to be an option, though.

[kadel]

Hi @bgrant0607, what was reason for removing @rtnpro from this? Or it was just something that happened during move to incubator?

[bgrant0607]

@kadel It just happened during the move. Only org members can be assigned to issues and PRs. I had to invite all kompose contributors to the kubernetes-incubator org.

[kadel]

@bgrant0607 Thank you. I thought that this was it.

[pradeepto]

Can this issue be closed via #206 ? cc @surajssd @rtnpro

[surajssd]

since #206 is merged, closing this in favour of more specific issue #353