kompose.volume.size label is not working

[bongole]

kompose.volume.size label is not working.
I tested on macOS 10.13.3 and brew installed kompose.

# test.yaml 
version: '2'
services:
  db:
    image: postgres:10.1
    labels:
      kompose.volume.size: 1Gi
    volumes:
      - db-data:/var/lib/postgresql/data

$ kompose version
1.8.0 ()

$ ls
test.yaml

$ kompose convert -f test.yaml
INFO Kubernetes file "db-service.yaml" created
INFO Kubernetes file "db-deployment.yaml" created
INFO Kubernetes file "db-data-persistentvolumeclaim.yaml" created

$ ls
db-data-persistentvolumeclaim.yaml db-deployment.yaml db-service.yaml test.yaml

$ cat db-data-persistentvolumeclaim.yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  creationTimestamp: null
  labels:
    io.kompose.service: db-data
  name: db-data
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 100Mi # <-- not 1Gi
status: {}

[hangyan]

It seems it's only working in compose v3 now, I will loop into it to see why in v1/v2 not working

[emmasteimann]

This is still not working for me. I'm using compose v3. Same error.

[emmasteimann]

Does it have something to do with the only modifying storage size if .Vfrom source is blank?

kompose/pkg/transformer/kubernetes/kubernetes.go

Lines 494 to 510 in 0c01309

	if volume.VFrom == "" {
	defaultSize := PVCRequestSize
	for key, value := range service.Labels {
	if key == "kompose.volume.size" {
	defaultSize = value
	}
	}
	createdPVC, err := k.CreatePVC(volumeName, volume.Mode, defaultSize)
	if err != nil {
	return nil, nil, nil, errors.Wrap(err, "k.CreatePVC failed")
	}
	PVCs = append(PVCs, createdPVC)
	}