new behavior of kompose delete

[ngtuna]

Adding flag -a/--all in order to delete all resources.
Consider to rename to kompose rm

[janetkuo]

docker-compose rm is used for removing "stopped" service containers, whereas kubectl delete can (and often) be used to remove the running ones.

[ngtuna]

Thanks @janetkuo for pointing it out. I am not thinking about kompose delete much right now. Paying more attention on kompose up. However, let's say we can have kompose rm to firstly stop containers running on k8s and then remove them. Don't want to be duplicated with kubectl delete but somehow we can add kompose stop to only do stop action. However, we should be very careful to not going into the same way last time when we overlapped kubectl functions. Interactive mode still be good option to go.

[ngtuna]

So, after some investigating, I see we need a thing is in contrast with kompose up. So I suggest:

- kompose down --file/--bundle <input_file> : delete deployment and svc (default: docker-compose.yml)
- kompose down --all : delete all resources (deployment, rc, svc, ds)

Anything else ?
/cc @janetkuo @Runseb

[janetkuo]

Is kompose down --all going to delete all resources in the system, regardless if it's created by kompose or not? Not sure if it's expected behavior from the users' perspective -- depends on their work flow

[ngtuna]

Yes it's a critical action. We can ask for confirmation like this:

$ kompose down --all
This action is going to delete all resources in all namespaces (except kube-system) in the kubernetes cluster. 
Are you sure to continue ? (y/n)

[sebgoa]

I don't think kompose down should delete everything. It should only delete the resources that the conversion created.

kompose down -f docker-voting.yml

should delete the deployments and services that it creates.

At least that's what I would expect.

[ngtuna]

So I will go merging kompose down without supporting --all flag. We can make a follow-up PR for this later.

[ngtuna]

Close via #113