Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes/klog Loading
base: v2.70.0
Choose a base ref
...
head repository: kubernetes/klog Loading
compare: v2.70.1
Choose a head ref
  • 6 commits
  • 5 files changed
  • 2 contributors

Commits on Jun 29, 2022

  1. ktesting: use black box testing

    It makes it more obvious what calls to the ktesting API will look like in real
    code.
    pohly committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    66544b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. ktesting: fix type assertion

    Due a missing space, _TL was a variable of type NopTL instead
    of asserting that NopTL implements the TL interface.
    pohly committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    78f38f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. ktesting: stop using testing.T when test completes

    When testing.T.Log gets called after the test has completed, it panics. There's
    also a data race (kubernetes/kubernetes#110854).
    
    Normally that should never happen because tests should ensure that all
    goroutines have stopped before returning. But sometimes it is not possible to
    do that. ktesting now automatically protects against that by registering a
    cleanup function and redirecting all future output into klog.
    pohly committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    9405f8e View commit details
    Browse the repository at this point in the history
  2. contextual logging: enable by default again

    Commit 3c90bf9 accidentally changed the
    default for contextual logging from "enabled" to "disabled". The intention
    always was and still is to make the new API do something useful by default and
    only be more cautious in key Kubernetes binaries which have a feature gate.
    pohly committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    c2d5a45 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #337 from pohly/testing-logger-stop

    ktesting: handle test completion
    k8s-ci-robot committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    ea66a13 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Merge pull request #341 from pohly/contextual-logging-state-fix

    contextual logging: enable by default again
    k8s-ci-robot committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    33351c0 View commit details
    Browse the repository at this point in the history
Loading