Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes/klog Loading
base: v2.4.0
Choose a base ref
...
head repository: kubernetes/klog Loading
compare: v2.5.0
Choose a head ref
  • 19 commits
  • 11 files changed
  • 5 contributors

Commits on Nov 2, 2020

  1. Update go.mod

    sayanibhattacharjee committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    29a2d64 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #187 from sayanibhattacharjee/patch-1

    Update go.mod to require the latest version of logr
    k8s-ci-robot committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    f81e6a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Configuration menu
    Copy the full SHA
    d74d9f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5919b2f View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Merge pull request #192 from yuzhiquan/klog-testcase-cleanup

    remove unreachable if statement, and typo
    k8s-ci-robot committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    d47f4e8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #193 from yuzhiquan/newflag-check

    Check new klog flag's prefix
    k8s-ci-robot committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    199a06d View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Configuration menu
    Copy the full SHA
    bf3dc06 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #199 from pohly/fix-apidiff

    github: fix apidiff check
    k8s-ci-robot committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    ffd1719 View commit details
    Browse the repository at this point in the history
  3. fix go.sum

    Commit 29a2d64 bumped logr in go.mod without the corresponding change
    in go.sum, with the result that any go invocation (for example "go
    test .") leads to a modified repo.
    pohly committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    e354d34 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. Merge pull request #198 from pohly/fix-mod-sum

    fix go.sum
    k8s-ci-robot committed Nov 30, 2020
    1 Configuration menu
    Copy the full SHA
    ea3b07f View commit details
    Browse the repository at this point in the history
  2. add InfoSDepth and ErrorSDepth

    This is needed for wrappers like klogr which need to skip additional
    levels in the call stack.
    pohly committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    6b97b32 View commit details
    Browse the repository at this point in the history
  3. klogr: extend test coverage

    Error(), WithName() and sorting were not tested before.
    pohly committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    5fda116 View commit details
    Browse the repository at this point in the history
  4. klogr: add support for structured logging via klog

    Now that klog has support for structured logging, it makes sense to
    use that also through klogr. The log output without a structured
    logger becomes more readable and key/value semantic is not lost
    anymore with a structured logger.
    
    However, revising the output handling is a breaking change for those
    who depend on the traditional output. Therefore this is implemented in
    a backward compatible way:
    - code calling New() without parameters continues to work and
      gets the traditional behavior
    - deferring the complete output handling to klog is enabled
      via a functional option
    pohly committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    34b3f9f View commit details
    Browse the repository at this point in the history
  5. klogr: add NewWithOptions, revert New

    Adding the optional options to New breaks code which assigns New to a
    function pointer of the original type without options.
    
    To avoid that, a new NewWithOptions gets added. That new function can
    also use the better default of letting klog serialize key/value pairs.
    pohly committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    b344254 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. test: cleanup temporary file

    Signed-off-by: Li Zhijian <[email protected]>
    zhijianli88 committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    f5ba35b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Merge pull request #197 from pohly/klogr-output-format

    klogr output format
    k8s-ci-robot committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    8a7e496 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. klogr: implement WithCallDepth

    This implements WithCallDepth from logr v0.4.0 in klogr.
    pohly committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    e61bbb8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #207 from pohly/klogr-call-depth

    klogr call depth
    k8s-ci-robot committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    8ea19f8 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #205 from zhijianli88/master

    test: cleanup temporary file
    k8s-ci-robot committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    2427a79 View commit details
    Browse the repository at this point in the history
Loading