-
Notifications
You must be signed in to change notification settings - Fork 214
Comparing changes
Open a pull request
base repository: kubernetes/klog
base: v2.4.0
head repository: kubernetes/klog
compare: v2.5.0
- 19 commits
- 11 files changed
- 5 contributors
Commits on Nov 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 29a2d64 - Browse repository at this point
Copy the full SHA 29a2d64View commit details -
Merge pull request #187 from sayanibhattacharjee/patch-1
Update go.mod to require the latest version of logr
Configuration menu - View commit details
-
Copy full SHA for f81e6a7 - Browse repository at this point
Copy the full SHA f81e6a7View commit details
Commits on Nov 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d74d9f8 - Browse repository at this point
Copy the full SHA d74d9f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5919b2f - Browse repository at this point
Copy the full SHA 5919b2fView commit details
Commits on Nov 11, 2020
-
Merge pull request #192 from yuzhiquan/klog-testcase-cleanup
remove unreachable if statement, and typo
Configuration menu - View commit details
-
Copy full SHA for d47f4e8 - Browse repository at this point
Copy the full SHA d47f4e8View commit details -
Merge pull request #193 from yuzhiquan/newflag-check
Check new klog flag's prefix
Configuration menu - View commit details
-
Copy full SHA for 199a06d - Browse repository at this point
Copy the full SHA 199a06dView commit details
Commits on Nov 24, 2020
-
The ::add-path:: command was disabled (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/). One possible replacement should be to modify the content of $GITHUB_ENV (https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable).
Configuration menu - View commit details
-
Copy full SHA for bf3dc06 - Browse repository at this point
Copy the full SHA bf3dc06View commit details -
Merge pull request #199 from pohly/fix-apidiff
github: fix apidiff check
Configuration menu - View commit details
-
Copy full SHA for ffd1719 - Browse repository at this point
Copy the full SHA ffd1719View commit details -
Commit 29a2d64 bumped logr in go.mod without the corresponding change in go.sum, with the result that any go invocation (for example "go test .") leads to a modified repo.
Configuration menu - View commit details
-
Copy full SHA for e354d34 - Browse repository at this point
Copy the full SHA e354d34View commit details
Commits on Nov 30, 2020
-
1
Configuration menu - View commit details
-
Copy full SHA for ea3b07f - Browse repository at this point
Copy the full SHA ea3b07fView commit details -
add InfoSDepth and ErrorSDepth
This is needed for wrappers like klogr which need to skip additional levels in the call stack.
Configuration menu - View commit details
-
Copy full SHA for 6b97b32 - Browse repository at this point
Copy the full SHA 6b97b32View commit details -
Error(), WithName() and sorting were not tested before.
Configuration menu - View commit details
-
Copy full SHA for 5fda116 - Browse repository at this point
Copy the full SHA 5fda116View commit details -
klogr: add support for structured logging via klog
Now that klog has support for structured logging, it makes sense to use that also through klogr. The log output without a structured logger becomes more readable and key/value semantic is not lost anymore with a structured logger. However, revising the output handling is a breaking change for those who depend on the traditional output. Therefore this is implemented in a backward compatible way: - code calling New() without parameters continues to work and gets the traditional behavior - deferring the complete output handling to klog is enabled via a functional option
Configuration menu - View commit details
-
Copy full SHA for 34b3f9f - Browse repository at this point
Copy the full SHA 34b3f9fView commit details -
klogr: add NewWithOptions, revert New
Adding the optional options to New breaks code which assigns New to a function pointer of the original type without options. To avoid that, a new NewWithOptions gets added. That new function can also use the better default of letting klog serialize key/value pairs.
Configuration menu - View commit details
-
Copy full SHA for b344254 - Browse repository at this point
Copy the full SHA b344254View commit details
Commits on Jan 13, 2021
-
Signed-off-by: Li Zhijian <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f5ba35b - Browse repository at this point
Copy the full SHA f5ba35bView commit details
Commits on Jan 26, 2021
-
Merge pull request #197 from pohly/klogr-output-format
klogr output format
Configuration menu - View commit details
-
Copy full SHA for 8a7e496 - Browse repository at this point
Copy the full SHA 8a7e496View commit details
Commits on Jan 27, 2021
-
klogr: implement WithCallDepth
This implements WithCallDepth from logr v0.4.0 in klogr.
Configuration menu - View commit details
-
Copy full SHA for e61bbb8 - Browse repository at this point
Copy the full SHA e61bbb8View commit details -
Merge pull request #207 from pohly/klogr-call-depth
klogr call depth
Configuration menu - View commit details
-
Copy full SHA for 8ea19f8 - Browse repository at this point
Copy the full SHA 8ea19f8View commit details -
Merge pull request #205 from zhijianli88/master
test: cleanup temporary file
Configuration menu - View commit details
-
Copy full SHA for 2427a79 - Browse repository at this point
Copy the full SHA 2427a79View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.4.0...v2.5.0