Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change release flow from using goreleaser to build scripts #5239

Merged
merged 1 commit into from
Aug 25, 2023
Merged

change release flow from using goreleaser to build scripts #5239

merged 1 commit into from
Aug 25, 2023

Conversation

koba1t
Copy link
Member

@koba1t koba1t commented Jul 12, 2023

fix: #5220

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2023
@koba1t koba1t force-pushed the chore/change_release_flow branch 4 times, most recently from 0b9fdd5 to b24f59a Compare July 12, 2023 20:54
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2023
@koba1t koba1t force-pushed the chore/change_release_flow branch 10 times, most recently from 4956157 to 2df2fed Compare July 17, 2023 20:13
@koba1t koba1t force-pushed the chore/change_release_flow branch from 2df2fed to b3a65c5 Compare July 24, 2023 21:38
@koba1t
Copy link
Member Author

koba1t commented Jul 27, 2023

I try to publish in my fork: https://github.com/koba1t/kustomize/releases/tag/kustomize%2Fv5.0.0

@koba1t koba1t force-pushed the chore/change_release_flow branch from b3a65c5 to 5bb1d64 Compare July 27, 2023 13:11
@koba1t koba1t marked this pull request as ready for review July 27, 2023 13:11
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 27, 2023
@koba1t koba1t mentioned this pull request Jul 27, 2023
Closed
@natasha41575 natasha41575 self-assigned this Aug 16, 2023
natasha41575
natasha41575 reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Couple comments below.

Thanks for trying out the release on your fork. Could you also try out releasing api, kyaml and cmd/config on your fork so we can verify that those work well too? Thank you so much.

releasing/create-release.sh
additional_release_artifacts_arg=""

# build `kustomize` binary
if [[ "$module" == "kustomize" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to confirm the behavior:

  • If it is a kustomize release, then it will build and release the kustomize binary
  • For other modules like kyaml, it will just create a new release based on the published tag.

Is that right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your understanding is entirely correct!
Please check the details for the below releases!

#5239 (comment)

releasing/create-release.sh Outdated
# build date in ISO8601 format
build_date=$(date -u +'%Y-%m-%dT%H:%M:%SZ')
for os in linux darwin windows; do
for arch in amd64 arm64; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a couple other architectures for linux that we currently release for, linux s390x and linux ppc64le. You can see these on our releases, such as this one: https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.0.1

Can we include s390x and ppc64le for linux here as well?

Copy link
Member Author

@koba1t koba1t Aug 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
I added it.
b1717c8#diff-f360f726ff58796695d8f13298f80887a97e6910b9d31da50f462192f16edc82R47-R53

@koba1t
Copy link
Member Author

koba1t commented Aug 17, 2023

Hi @natasha41575

Could you also try out releasing api, kyaml and cmd/config on your fork so we can verify that those work well too?

No problem!
I add the test releases on every package.
(To be honest, I couldn't run other release tests when I publish PR because I received a rate limit on GitHub API...)

api: https://github.com/koba1t/kustomize/releases/tag/api%2Fv0.14.1
cmd/config: https://github.com/koba1t/kustomize/releases/tag/cmd%2Fconfig%2Fv0.11.4
kyaml: https://github.com/koba1t/kustomize/releases/tag/kyaml%2Fv0.14.4
kustomize: https://github.com/koba1t/kustomize/releases/tag/kustomize%2Fv5.1.2

natasha41575
natasha41575 reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Excited to try this out :) Thank you very much for working on this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit bd7f001 into kubernetes-sigs:master Aug 25, 2023
8 of 9 checks passed
@natasha41575 natasha41575 mentioned this pull request Aug 25, 2023
Closed
2 tasks
@koba1t koba1t deleted the chore/change_release_flow branch August 25, 2023 18:57
@koba1t koba1t mentioned this pull request Aug 31, 2023
Closed
@maxdanilov maxdanilov mentioned this pull request Oct 19, 2023
Closed
@MPV MPV mentioned this pull request Oct 20, 2023
Closed
@MPV
Copy link

MPV commented Oct 20, 2023

FYI this seems to have introduced:

This was referenced Oct 30, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@annasong20 annasong20 Awaiting requested review from annasong20

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Kustomize CI, release Improvements, telemetry, & refactors
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kustomize unable to produce windows and darwin ARM binaries
4 participants
@koba1t @k8s-ci-robot @MPV @natasha41575