Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetImageConfig should return default configs for the images #127

Open
jian-he opened this issue Jul 21, 2021 · 1 comment
Open

GetImageConfig should return default configs for the images #127

jian-he opened this issue Jul 21, 2021 · 1 comment

Comments

@jian-he
Copy link
Collaborator

jian-he commented Jul 21, 2021

Here we can return the default image, instead of return empty image

func (h *KubeDLHandler) GetImageConfig() *ImageConfig {
	cm := &v1.ConfigMap{}
	err := h.client.Get(context.Background(), types.NamespacedName{
		Namespace: constants.KubeDLSystemNamespace,
		Name:      constants.KubeDLConsoleConfig,
	}, cm)
	if err != nil {
		glog.Infof("get image config error: %v", err)
		return &ImageConfig{}
	}
@cbl315
Copy link

cbl315 commented Aug 17, 2021

/assign

Just a suggestion, it would be better that label the issues like other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants