-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI(tests) Use AssertCommand function in every test #1643
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
working on it ! pls assign |
Hey @akshat-kaushik thank you for your interest! Let us know if you have any questions. |
Hi!I would like to work on this issue if its not being solved?Can anyone assign me this issue |
7 tasks
Is this issue resolved? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Feature Request
Short Description
The CI tests have been updated to use the Eventually function in the ginkgo tests, however we need to update all the tests, only KSP tests were updated recently.
Is your feature request related to a problem? Please describe the use case.
Today we might get flakey tests and we would need to have a retry logic for executing commands.
in all of our tests
Describe the solution you'd like
A new AssertCommand function was added recently to the utils package. Use this function instead of the K8sExecInPod() in all of our tests:
KubeArmor/tests/util/kartutil.go
Line 614 in 8ceb083
NOTE: some the the exec operators do not compare/match with anything and are just meant for executing, in that case you can set Matchregexp(".*") wherever matching is not required.
The text was updated successfully, but these errors were encountered: