Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting environment variable names for data directory in docs and code? #7

Open
maptastik opened this issue Jul 26, 2020 · 1 comment

Comments

@maptastik
Copy link

In the documentation for this provider, the following instructions are offered for setting a custom data directory:

You can override this by setting an environment variable KOOP_DATA_DIR=.

After failing at this several times, I went to check out this provider's source code. src/model.js I found the following line where it appears the data directory is set:

const dataDir = koop.dataDir || process.env.DATA_DIR || './data'

When I changed the environment variable from KOOP_DATA_DIR to simply DATA_DIR, the provider finally worked. I am very new to working with NodeJS so I'm not super savvy at debugging, but from my understanding here, it looks like there is a conflict between the documentation and the actual code. Is this interpretation correct? If so, I'd be happy to either update the documentation or code.

@rgwozdz
Copy link
Member

rgwozdz commented Jul 27, 2020

Hey, @maptastik. Nice catch, yes, one of these needs to be changed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants