Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling let them know which line causes the error #80

Open
Tracked by #78
yasahi-hpc opened this issue Mar 11, 2024 · 1 comment · May be fixed by #133
Open
Tracked by #78

Error handling let them know which line causes the error #80

yasahi-hpc opened this issue Mar 11, 2024 · 1 comment · May be fixed by #133

Comments

@yasahi-hpc
Copy link
Collaborator

No description provided.

@yasahi-hpc
Copy link
Collaborator Author

yasahi-hpc commented Jul 15, 2024

Static assertion to Unary (fftshift, ifftshift) and Binary (Plan and fft functions) APIs.

  • Exec space and memory space consistency (all)
  • View rank and axes rank consistency (all)
  • precision consistency (Binary)
  • layout consistency (Binary)
  • rank consistency (Binary)
  • Introduce is_view_operatable_v for Unary operation
  • Introduce are_views_operatable_v for Binary operation
  • Introduce have_same_precision_v for Binary operation
  • Introduce have_same_layout_v for Binary operation
  • Introduce have_same_rank_v for Binary operation

Runtime assertion should be std::runtime_error with appropriate messages.
If there is inconsistency in extents, we cannot operate FFT.

  • Introduce a precondition wrapper
  • replace assert with std::runtime_error
  • Add runtime assertion to check choice of axes is applicable to a View

Examples to produce errors should be added.
Display the expected assertions.

  • Add an awful example to produce errors

Add CI for C++20 build

  • CUDA, HIP and THREAD build with C++ 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant