Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Support sounds outside 2 octave range using resource pack #47

Closed
ishland opened this issue May 2, 2020 · 1 comment · Fixed by #50
Closed

[Feature request] Support sounds outside 2 octave range using resource pack #47

ishland opened this issue May 2, 2020 · 1 comment · Fixed by #50
Labels
enhancement

Comments

@ishland
Copy link
Contributor

ishland commented May 2, 2020 •
edited
Loading

Support these sounds outside 2 octave range using SongPlayer#setEnable10Octave(boolean)
If set to true, enable these sounds.
If set to false, transpose these sounds.
@ishland ishland changed the title Support sounds outside 2 octave range using resource pack [Enhancement] Support sounds outside 2 octave range using resource pack May 2, 2020
@ishland ishland changed the title [Enhancement] Support sounds outside 2 octave range using resource pack [Feature request] Support sounds outside 2 octave range using resource pack May 2, 2020
@VoxPopuliZombiemold
Copy link

I would love to see support for this. I recently listened to a v4 note block studio track in full octave range via a data pack, and they sound great!!

NoteBlockAPI supporting this would god tier.

@ishland ishland mentioned this issue May 29, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support sounds outside 2 octave range using resource pack ishland/NoteBlockAPI
3 participants
@VoxPopuliZombiemold @koca2000 @ishland