Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current ctx._matchedRoute #93

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

mdenisov
Copy link

Fixes #34

Copy link

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It'd be lovely to have it secured by a test or two. Maybe https://github.com/ZijianHe/koa-router/blob/c0e9e088cd679f3c4030b73d8c0fc7b69e1ffecb/test/matched.test.js#L64-L98 ? (it'd need to be ported from ava to mocha though, just a general idea...)

@mdenisov
Copy link
Author

@falkenhawk done! added tests for new logic.

@niftylettuce niftylettuce merged commit 7030524 into koajs:master Jun 30, 2020
@mdenisov mdenisov deleted the feature/fix-issue-34 branch June 30, 2020 16:44
@niftylettuce
Copy link
Contributor

@koa/router v9.1.0 released to npm and mirrored to koa-router as well

https://github.com/koajs/router/releases/tag/v9.1.0

@BainDragneel
Copy link

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ctx. _matchedRoute is not the match route.
4 participants