-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] ctx.request.origin ignores proxy flag (X-Forwarded-Proto) #1746
Comments
Could not reproduce. Code looked OK. Behavior looked OK. When proxy option is on, any X-Forwarded-Proto value is shown as the protocol and ctx.protocol is consistent with ctx.request.origin. |
Sorry for late reply. I'll re-verify the consistency of ctx.protocol again. I did it before using a nginx reverse proxy + cloudflare, that may be causing the problem. |
Describe the bug
When using the proxy flag set to true, ctx.request.origin ignores it, returning http:https:// instead of https:// (taken from X-Forwarded-Proto, available in ctx.protocol)
Node.js version: v16.14.0
OS version: Debian 10
Description: With koa's proxy flag to true, ctx.request.origin returns wrong protocol because it doesn't match with the X-Forwarded-Proto header (available in ctx.protocol).
Actual behavior [app.proxy=true]
http:https://mywebsite.com
Expected behavior [app.proxy=true]
https://mywebsite.com
Code to reproduce
I didn't submit a pull request since this is a very simple bug and it requires a reverse proxy setup (like nginx) to reproduce
Checklist
The text was updated successfully, but these errors were encountered: