-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test against the http2 compatibility layer #1454
Comments
Hi @jonathanong 👋 I see this issue is open for quite some time now (with no work being logged / linked to the issue) and labeled as a help wanted. Can you confirm that issue is still open (with no work being done) and is up for grabs? 🙂 Many thanks! 🎉 |
This issue is open for grabs. My personal suggestion is that if you want to make a contributing PR just go for it. It'll get reviewed once pushed. To get started with HTTP/2 tests I suggest taking a look at available test and mimic these using http2 instead. |
Thank you for getting back to me @miwnwski. I will provide a PR some time this week. I'll post update once I have some. |
Hi @ognjenjevremovic, any update with this? |
Hey @jkomyno, apologize for my late response. I think I tried merging the files at first, with both tests included (and reading through the command line arguments, when starting the tests to determine which set of tests to run). If you wanted to give this issue a shot instead, please do feel free to do so as I'm not actively working on it. |
although we don't support the new HTTP2 APIs, we should run all our tests against both the
http
andhttp2
modules, using only the HTTP/1 APIeasiest method would be to set an env var like
KOA_TEST_HTTP_MODULE=http
and run tests with each option.The text was updated successfully, but these errors were encountered: