Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: knative/serving
base: knative-v1.13.0
Choose a base ref
...
head repository: knative/serving
compare: knative-v1.13.1
Choose a head ref
  • 1 commit
  • 16 files changed
  • 2 contributors

Commits on Feb 3, 2024

  1. [release-1.13] Don't drop traffic when upgrading a deployment fails (#… 

    …14864)

* Surface Replica failures over Progressing failures

When transforming the deployment status to the revision
we want to bubble up the more severe condition to Ready.

Since Replica failures will include a more actionable error
message this condition is preferred

* Stop always marking the revision healthy when the PA is Ready

This isn't accurate when the Revision has failed to rollout
an update to it's deployment

* Various updates to the revision reconciler

1. PA Reachability now depends on the status of the Deployment

If we have available replicas we don't mark the revision as
unreachable. This allows ongoing requests to be handled

2. Always propagate the K8s Deployment Status to the Revision.

We don't need to gate this depending on whether the Revision
required activation. Since the only two conditions we propagate
from the Deployment is Progressing and ReplicaSetFailure=False

3. Mark Revision as Deploying if the PA's service name isn't set

* test deployment failures don't drop traffic on upgrade

* fix boilerplate check

---------

Co-authored-by: dprotaso <[email protected]>
    @knative-prow-robot @dprotaso
    knative-prow-robot and dprotaso committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    41769de View commit details
    Browse the repository at this point in the history