-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special dates of type "Holiday" are not visible on the minicalendar #78
Comments
Thanks for reporting! This is kinda expected - see #31. "Holiday" type events are supposed to show up like free/holiday days - so, for example, weekend days. Which are just bold. I've made them as bold as possible ( |
Ah, I see, good point. I missed that, it's possible the bold was not "boldy" enough for me, or I was just expecting the holidays so be different than regular weekend days. For example, Easter (which is always on a Sunday) should be somehow different than regular Sundays. What do you feel about the following? NOT selected days
When the day is selected (applies to the day page and week overview page), keep the current background fill. It would no longer be visible in the minicalendar that it's a holiday (because we have a darker background now), but it shouldn't matter, since both the week and day pages have the long text of the holiday written in the page itself). How do you feel about that? |
I am not sure if this is intentional of not, I am guessing it's not and this is a bug:
If the day is a special day of type "Holiday", the minicalendar does not draw a square around that day. If the day has at least one entry of type "Event", it does. The example entries (1, 3, 13 and 14th of January) don't draw squares around 1 and 3, but they do for 13 and 14. The events are present in the day pages, so they are correctly saved to the PDF, it seems only the minicalendar if affected.
Screenshots:
The text was updated successfully, but these errors were encountered: