Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Dotted Itinerary Pages #103

Open
dhlogan opened this issue Oct 11, 2023 · 2 comments
Open

Support for Dotted Itinerary Pages #103

dhlogan opened this issue Oct 11, 2023 · 2 comments

Comments

@dhlogan
Copy link

dhlogan commented Oct 11, 2023

Dotted pages are my preferred background as I do alot of mindmaps as I'm creating my notes. Would love to have dotted pages instead of the lined pages if at all possible. Great work on this! Many thanks!

@gmg
Copy link

gmg commented Oct 29, 2023

I've made an attempt at this. Very rough at this stage, but you can see the results below. I have created the dots using a View component, 2*2 with 50% border radius and horizontal margins. I don't know if this is the best approach, but it seems to work OK. I do wonder about how well optimised it is to PDF rendering.

My code is probably horrible and is definitely incomplete, so I will not be submitting a PR for now. There is a link to the code below though, if someone wants to help finish it off.

What I have done:

  • Added styles for dots, dot lines, empty grid lines, and text grid lines
  • Added functions to render the various elements, alongside the existing line functions
  • Hard coded replacements of the line functions with grid functions for testing

What still needs to be done:

  • Add an option to the UI to select dot grid or lines (maybe in the general options tab?)
  • Add conditions to 'renderItineraryItem' to determine which type to render
  • Add to the config system so the dot grid option gets saved
  • Probably more things that I haven't thought of

Here is a gist with the code: https://gist.github.com/gmg/240243b785c2b8041147fc321275d820

Here is what it looks like:
recalendar-dotgrid

@gmg
Copy link

gmg commented Nov 6, 2023

I have now added the required UI elements and connected it to the Itinerary drawing component.

I have submitted this as a pull request here: #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants