-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pylama not compatible with pytest 3.7.0 #126
Comments
Appears to be an upstream regression: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pytest 3.7.0, recently released, does not work with the --pylama option, failing as follows:
It appears to be related to this change:
pytest-dev/pytest@fedc785
Tested on both Python 2.7 and 3.6, and confirmed that tests collect and linting occurs on
pytest==3.6.4
, but fails with the above error onpytest==3.7.0
It looks like pytest is expecting pylama to implememt/override
pytest.Package._collectfile()
, butpylama.pytest.PylamaItem
only inherits frompytest.File
andpytest.Item
. I'm not sure if the fix is also to inherit frompytest.Package
, or if this is an issue in pytest where they should be checking if the plugin inherits fromPackage
The text was updated successfully, but these errors were encountered: