New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELR needs "threshold_type" kwarg #17

Closed

kjhall01 opened this issue May 22, 2022 · 1 comment

Owner

kjhall01 commented May 22, 2022

ELR here uses thresholds in the range [0, 1] when it should, probably, be [mindata, maxdata].

The threshold and the input should be scaled to the same range.

Owner Author

kjhall01 commented Jun 2, 2022

hard-coded to use threshold in y-units. closing

kjhall01 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment