Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Validation needs to maintain chunking scheme #14

Closed
kjhall01 opened this issue Apr 15, 2022 · 1 comment
Closed

Cross Validation needs to maintain chunking scheme #14

kjhall01 opened this issue Apr 15, 2022 · 1 comment

Comments

@kjhall01
Copy link
Owner

every slice in the cross-validation process should return the same chunking scheme as the initial arguments, X & Y. Currently, It sometimes re-chunks across the S dimension (likely a by-product of xr.concat in the function definition).

Either have XCast accomodate multiple chunks along S/M (ideal) , or have cross validator maintain number of chunks along S/M.

@kjhall01
Copy link
Owner Author

Actually, XCast does accomodate multiple chunks along S/M. The problem here is xc.RankedTerciles, which uses xr.quantile which in turn uses dask apply_gu_func, which does NOT accommodate multiple S/M chunks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant