Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off-by-one error in generated kll.json for Col/Row #22

Closed
jbondeson opened this issue Oct 14, 2017 · 1 comment
Closed

Off-by-one error in generated kll.json for Col/Row #22

jbondeson opened this issue Oct 14, 2017 · 1 comment

Comments

@jbondeson
Copy link

jbondeson commented Oct 14, 2017 •
edited
Loading

The generated Col/Row data seems to be shifted for both the PixelIds and ScanCodes nodes.

Output for K-Type scancode_map.p3.kll (not the non-existent 120)

        "1": {
            "Col": 36,
            "Row": 7,
            "ScanCode": 1,
            "x": 0.0,
            "y": 0.0,
            "z": 0.0
        },
        "2": {
            "Col": 1,
            "Row": 1,
            "ScanCode": 2,
            "x": 38.1,
            "y": 0.0,
            "z": 0.0
        },
[...]
        "119": {
            "Col": 0,
            "Row": 2,
            "x": -10.41,
            "y": 0.0,
            "z": 0.0
        },
        "120": {
            "Col": 0,
            "Row": 1
        }
@jbondeson
Copy link
Author

Issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbondeson