Replace pystache with chevron #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pystache has been unmaintained for a long time, with the [last commit] to [defunkt/pystache] being from September 2014. By now it is not installable with up-to-date setuptools. Luckily, genanki uses only the most basic of mustache API, and [chevron] fills the gap nicely. Tests are passing for me again. [chevron]: https://github.com/noahmorrison/chevron [defunkt/pystache]: https://github.com/defunkt/pystache [last commit]: defunkt/pystache@17a5dfd
85ddf45
to
f8ee5ee
Compare
|
I just tested this, works fine and the changes look trivial enough. Hopefully @kerrickstaley will merge this soon. I believe this is the way to go. |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 95.29% 95.28% -0.02%
==========================================
Files 11 11
Lines 319 318 -1
==========================================
- Hits 304 303 -1
Misses 15 15
Continue to review full report at Codecov.
|
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pystache has been unmaintained for a long time, with the last commit
to defunkt/pystache being from September 2014. By now it is not
installable with up-to-date setuptools.
Luckily, genanki uses only the most basic of mustache API, and chevron
fills the gap nicely. Tests are passing for me again.