-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genanki.Note should have a field for the paths to its media files #60
Comments
I vote keeping it the way that it is now. The same media file can be referenced in many different ways. Might as well save yourself a headache engineering something so specific in and force the user to make sure they know what they want when specifying the media writes. The greatest utility your module provides is not having to manually generate that sqlite db. KISS where possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Instead of having a
.media_files
attribute onPackage
, it may be more ergonomic to have a.media_files
attribute on eachgenanki.Note
instance. The.media_files
for the overall package will then be computed by combining the lists for each individualNote
(removing duplicates).Need to think a little more about whether this design will handle all use-cases and whether it will be genuinely easier to use. One consideration is "static" media files; those still need to be specified at the package level.
The text was updated successfully, but these errors were encountered: