Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Bug in Akvfx.compute? #32

Open
noisecrime opened this issue Jan 26, 2022 · 1 comment
Open

Potential Bug in Akvfx.compute? #32

noisecrime opened this issue Jan 26, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@noisecrime
Copy link

I've been using Akvfx as the basis for supporting Windows Kinect V2 and was puzzled by this line in Akvfx.compute.

// Buffer index
uint idx = (577 - id.y) * 640 + id.x;

I cannot work out why its using 577 for the number of rows from the depth image?
Either I'm missing some other purpose in the shader or perhaps its just a typo?

As the depth image from Azure Kinect is 640x576 and I assume id.y goes from 0 to 575 should it be

uint idx = (575 - id.y) * 640 + id.x;

I.E the height of the image - 1 to account for id.y being from 0 to 575.

@keijiro keijiro self-assigned this Jan 26, 2022
@keijiro keijiro added the question Further information is requested label Jan 26, 2022
@keijiro
Copy link
Owner

keijiro commented Jan 26, 2022

I think it's simply a bug.

@keijiro keijiro added bug Something isn't working and removed question Further information is requested labels Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants