Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching between the Explorer v6 and the Explorer classic is leaking #312

Open
stof opened this issue Dec 10, 2019 · 1 comment
Open

Switching between the Explorer v6 and the Explorer classic is leaking #312

stof opened this issue Dec 10, 2019 · 1 comment

Comments

@stof
Copy link
Contributor

stof commented Dec 10, 2019

The easiest way to observe this is to use the React DevTools on keen.io. When you switch to the Explorer Classic, a new App root is mounted. But if you switch back to the Explorer v6, this root is not unmounted, but it is not reused either when switching again to Explorer Classic.
This means that switching multiple times between both explorers is leaking instances of the classic explorer.
@maciejrybaniec
Copy link
Contributor

Hi @stof, thank You for reporting the issue. I created a separate ticket in our mono-repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stof @maciejrybaniec