-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-2131] Incomplete documentation about the Spaceflights tutorial #527
Comments
Thank you for reporting it! We will address your feedback in the docs and spaceflight example code. |
Thanks for addressing it, @921kiyo. If there is still time, I'd like to add three more notes regarding the
shuttles:
type: kedro_tutorial.io.xls_local.ExcelLocalDataSet
filepath: data/01_raw/shuttles.xlsx
layer: raw |
Hey there @falcaopetri. Thanks for reporting this. It is not too late at all! I will add your additional comments to our ticket. In the meantime, if you'd like to fix the issues, feel free to make a PR and work on it 😄 We truly appreciate it! Chat soon. |
From @falcaopetri's comment:
I have the same question. Adding it to |
@guludo Apologies, just noticed this has been merged into |
Description
The docs regarding the Spaceflights tutorial are incomplete, which makes it harder to successfully finish it.
This has been partially discussed in kedro-org/kedro-community#58 (including the issue reproducibility). Therefore, I will discuss it in a complementary way.
Context
There is apparently an ongoing internal issue about improving the organization and sync between the repos
kedro-examples
,kedro-training
, andkedro-starter-spaceflights
(kedro-org/kedro-training#1).As I understood, spaceflight full-repo is moving from
kedro-examples/kedro-tutorial
tokedro-training/kedro/exercises/spaceflight
.I'm not sure about what is being tracked internally, so I will list what I've found related to Spaceflights'
requirements.txt
:kedro[pandas.CSVDataSet,pandas.ExcelDataSet]
in requirements. Still, it is not specified in the docs tutorial. This results in the missing requirementpandas
andxlrd
when trying to load the datasets in Set up the data.kedro-examples/kedro-tutorial
is also missing this requirement in itssrc/requirements.txt
, which yielded [KED-2027] Missing dependancies in spaceflights tutorial kedro-community#58.kedro-training
andkedro-starter-spaceflights
already have this requirement in theirsrc/requirements.txt
.Actionable
kedro-examples/kedro-tutorial
'srequirements.txt
should be updated to containkedro[pandas.CSVDataSet,pandas.ExcelDataSet]
.kedro[pandas.CSVDataSet,pandas.ExcelDataSet]
is required.Set up the spaceflights project#Install project dependencies
is probably the right place.Create a new project#kedro install
.kedro-examples
as the full source to the spaceflights project. I'm not sure, but I guess that this will/should be eventually changed tokedro-training/kedro-exercises/spaceflight
.I could work on 1., 2., and 3. if it makes sense (note that they are at 3 different repos).
PS: Sorry for the cross-repos references everywhere. I considered that here was the best place to report it.
The text was updated successfully, but these errors were encountered: