Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Dysgu Module Integration and Empty VCF File Output #93

Closed
poddarharsh15 opened this issue Jun 26, 2024 · 9 comments
Closed

Issue: Dysgu Module Integration and Empty VCF File Output #93

poddarharsh15 opened this issue Jun 26, 2024 · 9 comments

Comments

@poddarharsh15
Copy link

Description
I am currently working on adding Dysgu as a new module in nf-core/modules, with the aim of later incorporating it into the nf-core/sarek pipeline for Structural Variant (SV) calling.
(https://github.com/nf-core/sarek/tree/3.4.2)

Issue Details
The module has been created by me with assistance from other developers from nf-core/sarek @famosab. While Dysgu passes all the tests and works well within the module, it returns an empty VCF file (a text file) when run on the test data provided by the nf-core community. In theory, it should at least return an empty VCF file with a header, similar to other tools like Manta and Tiddit when run with the same data.

Steps to Reproduce
Create the Dysgu module in nf-core/modules.
Run Dysgu on the provided test data from the nf-core community.
Observe that the resulting VCF file is empty, lacking even the expected header.

Expected Behavior
The Dysgu module should produce a VCF file with a header, even if no variants are detected, similar to the behavior observed with Manta and Tiddit.

Test data files used for Dysgu (https://github.com/nf-core/test-datasets/tree/sarek3)
input.zip

Output VCF files from Manta and Tiddit runs on the same test data
sample1.manta.diploid_sv.vcf.gz
sample1.tiddit.vcf.gz

Could you please investigate this issue? I am tagging #sarek developers in this issue to help identify the problem. Your assistance is highly appreciated! @famosab

Thank you for your help.

@kcleal
Copy link
Owner

kcleal commented Jun 26, 2024

Thanks @poddarharsh15,
This should be no problem to add.

@poddarharsh15
Copy link
Author

I am tagging this issue from yesterday, as you helped me in improving the command line. This will ensure everything is together if we need further information. https://github.com/kcleal/dysgu/issues/92
Thank you again :)

@kcleal
Copy link
Owner

kcleal commented Jul 2, 2024

Hi @poddarharsh15 ,
dysgu 1.6.4 is available on pypi. It should be on conda in a few days.

@poddarharsh15
Copy link
Author

Thank you for the update, @kcleal. I will perform some test runs using the new versions and update you.

@poddarharsh15
Copy link
Author

Hi @kcleal
The tests were successfully passed, and I was able to create empty VCF files with headers. Thank you for the update again.
If you don't mind, could you please let me know how many days it will take for this version to be available on any conda channel?

@kcleal
Copy link
Owner

kcleal commented Jul 4, 2024

Hi @poddarharsh15,
Great. I will do some work on the build today - one of the dependencies is causing the build to fail at the moment. It might be fixed by the end of the day.

@kcleal
Copy link
Owner

kcleal commented Jul 5, 2024

Hi @poddarharsh15,
It should now be available on bioconda.

@kcleal kcleal closed this as completed Jul 5, 2024
@poddarharsh15
Copy link
Author

poddarharsh15 commented Jul 5, 2024

Thanks for the update, @kcleal I have successfully installed dysgu==1.6.4 package using bioconda, just one concern when i am running dysgu --version command it emits out dysgu, version 1.6.5
Is that okay?

@kcleal
Copy link
Owner

kcleal commented Jul 5, 2024

My apologies, I forgot to edit the tags on the release. This might cause a bit of confusion, so will have to add a new release to fix. There will be no changes other than fixing the version issue. Thanks for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants