Protocol says return "good" on success

[bigon]

Hello,

The dyndns protocol says that on success the server should return "good", but here it's returning "success"

This breaks the integrated "dyndns" feature of my ISP router

https://help.dyn.com/remote-access-api/return-codes/

[kbabioch]

Does it work when you change success to good in this line:

php-ddns/update.php

Lines 170 to 175 in 4af5251

	if ($ret === 0) {
	echo 'success';
	} else {

I think I took success from the output of nsupdate and it worked for me just fine, but I guess it depends on the client. Should be a trivial change, but let's first verify that it indeed fixes your problem.

[bigon]

Yes yes changing that line to "good" is indeed working (I was not clear enough)