ui.py split, ui performance improvement #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezanzeb
commented
Aug 15, 2021
Comment on lines
350
to
355
| for task, progress in task_progress: | ||
| if progress == 0: | ||
| # otherwise the ui becomes really laggy with too many files | ||
| continue | ||
|
|
||
| self.set_file_progress(task.sound_file, progress) |
There was a problem hiding this comment.
performance improved here
|
Nice, thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui.py was very long and therefore hard to navigate, now its classes are split into multiple files
Furthermore when converting too many files the interface became laggy because the progress of all rows was updated, even if it remained at 0. Except for this there were only refactoring changes without touching any logic.