Mp4mux tag msg fix #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I doubt gstreamer does m4a tags correctly https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/759#note_573415 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: https://bugs.launchpad.net/soundconverter/+bug/1883257
The mp4mux gstreamer pipeline plugin did not forward the tag messages sent by decodebin. A workaround was to branch the pipeline into a fakesink, which would cause those (duplicate) messages to not be hidden by a muxer.
Duplicate tag messages are actually a normal thing, the documentation even mentions it, so there is now less debug output when a duplicate tag message arrives by adding a check in append_tag. Especially when converting to flac I would see a huge number of tag logs.
The change to the readme was made because there actually is a encodebin, it's just very difficult to use. See https://stackoverflow.com/questions/62684838/how-do-you-figure-out-gstreamer-profile-strings on why. Also, considering that the profile string has to be added in order to determine which output format is being used, I don't see the extra value it would bring for us, since in that case we can also just use the encoders and muxers for the format in question like we already do depending on the output format.
Please try to convert some of your files with this change as well please, as I think this is a rather odd change to the gstreamer pipeline. If it doesn't, I'll try to add a new unittest that reproduces the error.