Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide menu when shortcut is pressed while menu is visible #558

Closed
mway opened this issue Aug 3, 2024 · 2 comments
Closed

Hide menu when shortcut is pressed while menu is visible #558

mway opened this issue Aug 3, 2024 · 2 comments
Labels
contributions welcome It would be cool if somebody worked on this one feature request New feature or request good first issue Good for newcomers

Comments

@mway
Copy link

mway commented Aug 3, 2024

Description

Have been following this project for a while - it's looking great!

I think it would be nice if the shortcut toggled Kando's visibility. For example, given shortcut ⌃⌘R:

  1. Press ⌃⌘R, menu shows
  2. Press ⌃⌘R again (instead of selecting an item), menu hides

A really small thing but it's nice to not have to click the middle icon to dismiss the menu if I open it and then change my mind.

Affected Desktop Environments

All

Additional Information

No response

@mway mway added the feature request New feature or request label Aug 3, 2024
@mway mway changed the title Hide Kando when shortcut is pressed while Kando is visible Hide menu when shortcut is pressed while menu is visible Aug 3, 2024
@Schneegans
Copy link
Contributor

Schneegans commented Aug 4, 2024

Thanks for the suggestion! There are currently three ways for closing a menu without selecting anything:

  • Click the center item
  • Hit the Escape key
  • Right mouse button click

Especially the right mouse button is pretty convenient and gets into your muscle memory quite quickly. I guess we could add "pressing the hotkey again" to this list, but at the same time we would have to make sure that it does not interfere with Turbo Mode which may be quite challenging. So that people do not hide the menu by accident...

So it's pretty low on my priority list, but anyone is interested, feel free to add this feature! I can happily provide some pointers to the relevant source files.

@Schneegans Schneegans added contributions welcome It would be cool if somebody worked on this one good first issue Good for newcomers labels Aug 4, 2024
@Schneegans
Copy link
Contributor

I thought a bit about this and I think that this is impossible to add without breaking turbo mode as it works right now. If you keep a shortcut pressed to use turbo mode, for Kando it looks like the shortcut was pressed again (as the initial shortcut was captured at OS level) and Kando now receives the key-repeat events.

Given all the other options to close a menu, it is also not that important, I guess.

@Schneegans Schneegans closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome It would be cool if somebody worked on this one feature request New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants