Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request]: add search to schema checks #4577

Open
huv1k opened this issue Apr 24, 2024 · 3 comments
Open

[feature-request]: add search to schema checks #4577

huv1k opened this issue Apr 24, 2024 · 3 comments
Labels
enhancement New feature or request that adds new things or value to Hive

Comments

@huv1k
Copy link

huv1k commented Apr 24, 2024

It would simplify the workflow of searching schema checks with one type. Trying to find a check that contains specific changes can be time-consuming. I could see having a simple search field that would filter all checks that don't include specific strings.

CleanShot 2024-04-24 at 11 27 24@2x

@n1ru4l n1ru4l added the enhancement New feature or request that adds new things or value to Hive label Apr 30, 2024
@n1ru4l
Copy link
Collaborator

n1ru4l commented Apr 30, 2024

How often is it necessary to search a schema check for changes?
We already thought about searching schema versions via changes (e.g. you want to figure out which schema publish resulted in a change and who did it), but never schema checks 🤔

@huv1k
Copy link
Author

huv1k commented Apr 30, 2024

For example, somebody removes a field or operation that doesn't have any usage => is not used in production etc. This doesn't count in code that is for example in code, but it's not yet used. It can happen that this change breaks CI checks in repository that have this code inside, so I would like to find what removed this field so we can figure out who is responsible for it and followup with deprecation in another repo 🙌

@capaj
Copy link
Collaborator

capaj commented Jun 18, 2024

I think we're storing schema changes in the DB, so it should be doable to run ILIKE search on that. Would such simple search query work for you @huv1k ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request that adds new things or value to Hive
Projects
None yet
Development

No branches or pull requests

3 participants