Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mel-computations cli help text "=" missing #3010

Closed
boeddeker opened this issue Jan 30, 2019 · 2 comments
Closed

mel-computations cli help text "=" missing #3010

boeddeker opened this issue Jan 30, 2019 · 2 comments

Comments

@boeddeker
Copy link
Contributor

The help text of compute-mfcc-feats says that the --high-freq < 0 is the offset from Nyquist.
But the code says it is --high-freq <= 0.
In my mind should the help text say --high-freq <= 0 is the offset from Nyquist.

Here the code positions:

"High cutoff frequency for mel bins (if < 0, offset from Nyquist)");

if (opts.high_freq > 0.0)

@danpovey
Copy link
Contributor

OK, you can make a PR if you have time.

@boeddeker
Copy link
Contributor Author

Sure, I opened a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants