Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 1.5 and higher will work this way by default #3

Closed
garrison opened this issue May 5, 2020 · 6 comments
Closed

Julia 1.5 and higher will work this way by default #3

garrison opened this issue May 5, 2020 · 6 comments

Comments

@garrison
Copy link

garrison commented May 5, 2020

Just noting here that this package will no longer be necessary as of julia 1.5 now that JuliaLang/julia#34331 is merged. It will still be useful to have on older versions of julia, though.

@jw3126
Copy link
Owner

jw3126 commented May 7, 2020

Good point thanks! A PR with a depwarn on 1.5 would be welcome.

@garrison
Copy link
Author

garrison commented May 7, 2020

When I filed this issue, I thought it might actually be better just to update the README and have the code do nothing on versions 1.5 and higher. This way, somebody can have a package that relies on it while working on both julia 1.0 and 1.5, and there is not a constant (annoying) warning when running under 1.5.

Even better, I suppose (but I am not certain it is worth the effort) would be to integrate this feature into Compat.jl, since it is a package that exists exactly for cross-version compatibility, using the macro you provided as a starting point. There may be some tweaking required to get the semantics to match exactly. Then the current package could warn on all versions of julia that it is deprecated and that people are encouraged to use Compat instead if they need compatibility on julia versions prior to 1.5.

Again, I think this would make much more sense, but just adding a note to the README would be a good first step for now. Perhaps a second step would be to file an issue with Compat pointing here, in case anybody wants to use it as a starting point for integrating the functionality there.

@jw3126
Copy link
Owner

jw3126 commented May 7, 2020

Sounds good, I added a note to the README

@garrison
Copy link
Author

garrison commented May 7, 2020

And I opened JuliaLang/Compat.jl#699

@omus
Copy link

omus commented Jul 28, 2021

Included in Compat.jl as of version 3.32.0

@garrison
Copy link
Author

Great!

Then the current package could warn on all versions of julia that it is deprecated and that people are encouraged to use Compat instead if they need compatibility on julia versions prior to 1.5.

I suppose this is the only thing left to do then before closing this issue -- if someone is motivated enough.

@jw3126 jw3126 closed this as completed in 79306ad Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants